[FIX] SqlTable use empty string instead of None for StringVariable#5120
Merged
lanzagar merged 4 commits intobiolab:masterfrom Dec 18, 2020
Merged
[FIX] SqlTable use empty string instead of None for StringVariable#5120lanzagar merged 4 commits intobiolab:masterfrom
lanzagar merged 4 commits intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5120 +/- ##
==========================================
- Coverage 84.77% 84.77% -0.01%
==========================================
Files 286 286
Lines 60084 60078 -6
==========================================
- Hits 50938 50929 -9
- Misses 9146 9149 +3 |
668fcd4 to
b408ba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Nonein the String variable.Description of changes
SqlRowInstanceand usingInstanceinstead since it seems that Instance does the same in the__init__thatSqlRowInstanceused to do. It also correctly replaces None with the '' (empty string). Hope I didn't missee anything.Includes