Skip to content

[FIX] OWImpute: Preserve default method setting#5181

Merged
janezd merged 4 commits intobiolab:masterfrom
ales-erjavec:fixes/impute-default-method-setting
Jan 15, 2021
Merged

[FIX] OWImpute: Preserve default method setting#5181
janezd merged 4 commits intobiolab:masterfrom
ales-erjavec:fixes/impute-default-method-setting

Conversation

@ales-erjavec
Copy link
Copy Markdown
Contributor

Issue
  • The default method changes to 'Fixed values' when the widget receives first data.
    Steps:
    * create an 'Impute' widget - do not connect it yet
    * change the default method to say 'Average/Most frequent'
    * connect it to 'File', the method changes to 'Fixed values'

  • The date time setting is reset at widget creation and is not restored.

Description of changes
  • Preserve the default method on set_data
  • Do not reset default_time in init
  • Do not switch to 'Fixed values' by tabbing over controls
  • Fix type hint comment location
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2021

Codecov Report

Merging #5181 (b69a634) into master (1d2626e) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #5181      +/-   ##
==========================================
- Coverage   84.79%   84.79%   -0.01%     
==========================================
  Files         286      286              
  Lines       60189    60192       +3     
==========================================
+ Hits        51036    51038       +2     
- Misses       9153     9154       +1     

@janezd janezd self-assigned this Jan 15, 2021
@janezd janezd merged commit f079588 into biolab:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants