[FIX] OWImpute: Preserve default method setting#5181
Merged
janezd merged 4 commits intobiolab:masterfrom Jan 15, 2021
Merged
Conversation
The default method would change to 'Fixed values' whenever the widget receives first data.
Codecov Report
@@ Coverage Diff @@
## master #5181 +/- ##
==========================================
- Coverage 84.79% 84.79% -0.01%
==========================================
Files 286 286
Lines 60189 60192 +3
==========================================
+ Hits 51036 51038 +2
- Misses 9153 9154 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The default method changes to 'Fixed values' when the widget receives first data.
Steps:
* create an 'Impute' widget - do not connect it yet
* change the default method to say 'Average/Most frequent'
* connect it to 'File', the method changes to 'Fixed values'
The date time setting is reset at widget creation and is not restored.
Description of changes
default_timein initIncludes