Closed
Conversation
3 tasks
irgolic
force-pushed
the
pythonscript-console
branch
2 times, most recently
from
f857549 to
e3de711
Compare
markotoplak
requested changes
Jul 7, 2021
Member
markotoplak
left a comment
markotoplak
left a comment
There was a problem hiding this comment.
We need to ensure that old workflows keep the same functionality. For old workflows, the in-process kernel needs to be used.
To achieve this, the settings version needs to increase in this PR, and then, if old settings are detected, enable the old kernel for that process. If there are other changes to the behavior (I might have missed something), also consider a compatibility mode as in #3810.
This is a serious blocker, but fortunately easy to fix.
irgolic
force-pushed
the
pythonscript-console
branch
2 times, most recently
from
2b3a8a4 to
7c3cf63
Compare
I can't run WidgetPreview without this removed. It'll be replaced by a dedicated kernel soon.
For now only uses its pygments stuff in editor. A later PR will implement more with this requirement.
Relies on setting darkMode property in QApplication
irgolic
force-pushed
the
pythonscript-console
branch
from
7c3cf63 to
7e909f3
Compare
If flicking in-process on and off, before this change, it could get stuck on 'Injecting Variables'
Orange already does its own patching, and does not expose file descriptors for the patched out streams. Even if this functionality is added to orange and canvas-core, many test runners (JetBrains) do not, and the only case handled in the ipykernel library is for pytest.
irgolic
force-pushed
the
pythonscript-console
branch
from
7e909f3 to
d3a56c2
Compare
irgolic
force-pushed
the
pythonscript-console
branch
from
12a05ea to
855a00e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OWPythonScript PRs:
#5208 -> here
Issue
The console hangs on execution. Also it could be prettier.
Description of changes
Before
After
The console now launches a python kernel in a separate process.
Some new files:
This is variable injection ZMQ stuff between console and kernel. It facilitates a pipe-based IPC (inter-process communication) solution. Makes a great prototype for client/server architecture in Orange. Apparently
ipc://isn't supported on Windows though TODO.Uses python_serialize.py's OrangeZMQMixin. Also does a lot of work maintaining current state (transferring variables, executing script), also triggering signals that indirectly change the widget's status message.
Uses python_serialize.py's OrangeZMQMixin. Simplest of the bunch, just make sure not to import Qt or Orange here or it hangs the kernel on startup (making it timeout).
I tried making the kernel fast, but if the timeout is an issue, I can extend it. From what I've seen, it only causes a small UI glitch.
Includes