[FIX] Rank: Switch to manual selection on deselect#5271
Merged
markotoplak merged 1 commit intobiolab:masterfrom Feb 19, 2021
Merged
[FIX] Rank: Switch to manual selection on deselect#5271markotoplak merged 1 commit intobiolab:masterfrom
markotoplak merged 1 commit intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5271 +/- ##
=======================================
Coverage 85.19% 85.19%
=======================================
Files 300 300
Lines 60977 60981 +4
=======================================
+ Hits 51950 51955 +5
+ Misses 9027 9026 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5126.
Description of changes
view.pressed(QModeIndex)is not emitted when index is invalid.selectionModel().selectionChanged(...)would not distinguish between changes because of clicking and programmatic changes. Hence I overrodemousePressEvent, which, in super-super-class calls theselect.I want add tests because I don't know how to.
Includes