[FIX] Errors when converting negative timestamps on Windows#5388
Merged
thocevar merged 3 commits intobiolab:masterfrom Apr 9, 2021
Merged
[FIX] Errors when converting negative timestamps on Windows#5388thocevar merged 3 commits intobiolab:masterfrom
thocevar merged 3 commits intobiolab:masterfrom
Conversation
Use explicit utc offset instead.
Codecov Report
@@ Coverage Diff @@
## master #5388 +/- ##
==========================================
+ Coverage 86.29% 86.31% +0.02%
==========================================
Files 301 301
Lines 61193 61244 +51
==========================================
+ Hits 52808 52865 +57
+ Misses 8385 8379 -6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: gh-5345
datetime.fromtimestampandtime.gmtimeraise OSError for negative timestamps on Windows.Description of changes
Avoid use of
gmtimeandfromtimestampIncludes