DBSCAN: Optional normalization#5428
Merged
markotoplak merged 1 commit intobiolab:masterfrom May 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5428 +/- ##
==========================================
- Coverage 86.14% 86.14% -0.01%
==========================================
Files 303 303
Lines 61592 61607 +15
==========================================
+ Hits 53061 53072 +11
- Misses 8531 8535 +4 |
Member
|
@VesnaT, thanks, looks good to me! |
Member
Member
|
The other preprocessors are necessary if you do not want the widget to work at all with missing values or some discrete columns. If your data does not have either they will not do anything anyway. The UI's are different because one allows distance measurement method setting and the other does not. |
Contributor
|
But preprocessors should be listed in documentation, I guess. For this widget and for others. |
Member
|
Could we automate/standardize preprocessors, to make them a bit more transparent? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue
Fixes #5424
Description of changes
Add a check box to normalize/not normalize the input dataset. The check box is checked by default.
Includes