[FIX] owheatmap: Fix assertion error when restoring selection#5517
Merged
janezd merged 1 commit intobiolab:masterfrom Jul 27, 2021
Merged
Conversation
... when input does not have enough columns for clustering.
dea98f8 to
95b35c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #5517 +/- ##
==========================================
- Coverage 86.38% 86.37% -0.01%
==========================================
Files 304 304
Lines 61753 61753
==========================================
- Hits 53344 53341 -3
- Misses 8409 8412 +3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Heatmap widget raises an assertion error when restoring selection and the input data has only a single column and columns clustering is selected.
Easiest way to test is to File -> Heatmap, select column clustering and select a couple of rows in the heatmap, then duplicate/copy/paste the Heatmap, add File -> Select Columns, select single column in Select Columns and connect Select Columns -> Heatmap (2)
Description of changes
Fix assertion error when restoring selection
Includes