[ENH] oweditdomain: Indicate variables in error state#5732
Merged
janezd merged 2 commits intobiolab:masterfrom Dec 17, 2021
Merged
[ENH] oweditdomain: Indicate variables in error state#5732janezd merged 2 commits intobiolab:masterfrom
janezd merged 2 commits intobiolab:masterfrom
Conversation
Contributor
|
Exactly what I had in mind. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5732 +/- ##
==========================================
+ Coverage 86.13% 86.14% +0.01%
==========================================
Files 315 315
Lines 66148 66178 +30
==========================================
+ Hits 56976 57010 +34
+ Misses 9172 9168 -4 |
bce90fc to
611b4b0
Compare
(have duplicated names)
611b4b0 to
b24ab28
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ref: gh-5731
Description of changes
Indicate an error state (duplicated name) in the variable list view.
Includes