Skip to content

[FIX] owfeatureconstructor: Always update models on data change #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janezd merged 1 commit into from
Feb 3, 2022
Merged

[FIX] owfeatureconstructor: Always update models on data change #5804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions Orange/widgets/data/owfeatureconstructor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,27 +681,20 @@ def setData(self, data=None):
self.data = data
self.expressions_with_values = False

self.descriptors = []
self.currentIndex = -1
if self.data is not None:
descriptors = list(self.descriptors)
currindex = self.currentIndex
self.descriptors = []
self.currentIndex = -1
self.openContext(data)
self.fix_button.setHidden(not self.expressions_with_values)

if descriptors != self.descriptors or \
self.currentIndex != currindex:
# disconnect from the selection model while reseting the model
selmodel = self.featureview.selectionModel()
selmodel.selectionChanged.disconnect(
self._on_selectedVariableChanged)
# disconnect from the selection model while reseting the model
selmodel = self.featureview.selectionModel()
selmodel.selectionChanged.disconnect(self._on_selectedVariableChanged)

self.featuremodel[:] = list(self.descriptors)
self.setCurrentIndex(self.currentIndex)

selmodel.selectionChanged.connect(
self._on_selectedVariableChanged)
self.featuremodel[:] = list(self.descriptors)
self.setCurrentIndex(self.currentIndex)

selmodel.selectionChanged.connect(self._on_selectedVariableChanged)
self.fix_button.setHidden(not self.expressions_with_values)
self.editorstack.setEnabled(self.currentIndex >= 0)

def handleNewSignals(self):
Expand Down