[FIX] Linear Projection: Fix LDA#5828
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5828 +/- ##
==========================================
+ Coverage 86.20% 86.21% +0.01%
==========================================
Files 316 316
Lines 66618 66630 +12
==========================================
+ Hits 57426 57444 +18
+ Misses 9192 9186 -6 |
|
Adding the class to effective_data makes sense, but the _invalidated/_domain_invalidated flags should be changed accordingly. The following example does not work correctly: |
| def effective_data(self): | ||
| return self.data.transform(Domain(self.effective_variables)) | ||
| return self.data.transform(Domain(self.effective_variables, | ||
| self.data.domain.class_vars)) |
There was a problem hiding this comment.
I just realised this wont work because class variable is duplicated when selected in effective variables.
Issue
Fixes #5359
Description of changes
I thought about removing the overriden
effective_data(which also fixes LDA), but then saw that it was done based on a talk between @janezd and @VesnaT (#4846 (comment)) who must have had a good reason for it.So I just added the class to effective_data, but @janezd or @VesnaT should confirm that that makes sense.
Includes