[FIX] Scatter Plot: Replot when input features change#5837
Merged
janezd merged 1 commit intobiolab:masterfrom Feb 23, 2022
Merged
[FIX] Scatter Plot: Replot when input features change#5837janezd merged 1 commit intobiolab:masterfrom
janezd merged 1 commit intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5837 +/- ##
==========================================
+ Coverage 86.20% 86.24% +0.03%
==========================================
Files 316 315 -1
Lines 66627 66675 +48
==========================================
+ Hits 57437 57504 +67
+ Misses 9190 9171 -19 |
Contributor
|
Just a though: what about renaming Currently, there exist If you prefer to keep |
8d09644 to
589345f
Compare
Contributor
Author
|
I liked the suggestion so I changed the name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Scatter Plot widget does not always refresh the plot on input features change. To obtain this behaviour the features must be connected before the data (see the included test).
To reproduce, open the attached workflow and change the selection in the Correlations widget. The plot in Scatter Plot does not change accordingly.
untitled.ows.zip
Description of changes
_attrs_invalidatedvariable in Scatter Plot widgetIncludes