Skip to content

[FIX] owcsvimport: Reduce sample size#5960

Merged
janezd merged 1 commit intobiolab:masterfrom
ales-erjavec:fixes/owcsvimport-sample-size
May 6, 2022
Merged

[FIX] owcsvimport: Reduce sample size#5960
janezd merged 1 commit intobiolab:masterfrom
ales-erjavec:fixes/owcsvimport-sample-size

Conversation

@ales-erjavec
Copy link
Contributor

Issue

Opening some files for the first time can take a surprising amount of time before the detailed import options dialog is displayed.

Example file

dataset.csv

The time is spent in csv.Sniffer.sniff

Description of changes

Reduce sample text size from 1MiB to 4KiB

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #5960 (0e4b994) into master (5658a6f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5960   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files         315      315           
  Lines       67068    67068           
=======================================
  Hits        57891    57891           
  Misses       9177     9177           

@janezd janezd self-assigned this May 6, 2022
@janezd janezd merged commit 4a93f6c into biolab:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants