[FIX] Feature Constructor cast function is not picklable#6002
Merged
markotoplak merged 2 commits intobiolab:masterfrom Aug 10, 2022
Merged
[FIX] Feature Constructor cast function is not picklable#6002markotoplak merged 2 commits intobiolab:masterfrom
markotoplak merged 2 commits intobiolab:masterfrom
Conversation
854a4e5 to
4b4aff7
Compare
Codecov Report
@@ Coverage Diff @@
## master #6002 +/- ##
==========================================
+ Coverage 86.59% 86.63% +0.03%
==========================================
Files 315 315
Lines 67317 67560 +243
==========================================
+ Hits 58295 58531 +236
- Misses 9022 9029 +7 |
4b4aff7 to
830b398
Compare
830b398 to
8e5d632
Compare
8e5d632 to
c2e904d
Compare
c2e904d to
e33b38f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Feature Constructor can construct
compute_valuewhich are not picklable (defined in local function scope):orange3/Orange/widgets/data/owfeatureconstructor.py
Lines 1032 to 1033 in cd3dfee
orange3/Orange/widgets/data/owfeatureconstructor.py
Lines 1042 to 1047 in cd3dfee
Fixes gh-5918
Description of changes
castfunction passed to FeatureFunc picklable.Includes