[FIX] TableModel: Define foreground color when providing background#6011
Merged
PrimozGodec merged 1 commit intobiolab:masterfrom Jun 10, 2022
Merged
Conversation
... to ensure text is contrasted against the background when system text color is light.
Codecov Report
@@ Coverage Diff @@
## master #6011 +/- ##
==========================================
- Coverage 86.58% 86.58% -0.01%
==========================================
Files 315 315
Lines 67281 67285 +4
==========================================
+ Hits 58258 58261 +3
- Misses 9023 9024 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In 'Data Table' On dark styles the contrast of text on background for metas and class columns is poor.
Before
After
Description of changes
Define foreground color when providing background to ensure text is contrasted against the background when system text color is light.
Includes