Skip to content

[FIX] Server embedder - send bytes as content#6051

Merged
markotoplak merged 1 commit intobiolab:masterfrom
PrimozGodec:httpx-fix
Sep 9, 2022
Merged

[FIX] Server embedder - send bytes as content#6051
markotoplak merged 1 commit intobiolab:masterfrom
PrimozGodec:httpx-fix

Conversation

@PrimozGodec
Copy link
Contributor

Issue

According to httpx sending bytes as data parameters is deprecated.

Description of changes

Use content for sending bytes and data for sending dictionaries

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title server embedder - send bytes as content [FIX] Server embedder - send bytes as content Jul 1, 2022
@PrimozGodec
Copy link
Contributor Author

/rebase

@PrimozGodec
Copy link
Contributor Author

/rebase

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #6051 (dc1693a) into master (263b782) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head dc1693a differs from pull request most recent head 189fc02. Consider uploading reports for the commit 189fc02 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6051      +/-   ##
==========================================
- Coverage   86.62%   86.62%   -0.01%     
==========================================
  Files         315      315              
  Lines       67559    67480      -79     
==========================================
- Hits        58524    58454      -70     
+ Misses       9035     9026       -9     

@PrimozGodec
Copy link
Contributor Author

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants