Skip to content

Remove PyQt5 requirements from setup#6154

Closed
PrimozGodec wants to merge 1 commit intobiolab:masterfrom
PrimozGodec:pyqt5
Closed

Remove PyQt5 requirements from setup#6154
PrimozGodec wants to merge 1 commit intobiolab:masterfrom
PrimozGodec:pyqt5

Conversation

@PrimozGodec
Copy link
Copy Markdown
Contributor

Issue

PyQt5 requirement disables users from using PyQt6
I tried to check PyQt more generally but noticed the following things:

  • pip install . will build the wheel in a separate isolated process and will not see whether PyQt is in the requirement (so PyQt will always be installed independently from the environment)
  • pip install orange3 installs from wheels that always have pyqt5 requirements inside (and setup.py is not there)

So checking whether PyQt is installed or not does make sense. PyQt will always be put in dependencies.

Description of changes

To avoid confusion in Conda environments (having PyQt both from PyPi and conda), I am removing this dependency.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Copy Markdown
Member

Duplicate of #6153 .

@PrimozGodec PrimozGodec deleted the pyqt5 branch September 30, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants