Remove PyQt5 requirements from setup#6154
Closed
PrimozGodec wants to merge 1 commit intobiolab:masterfrom
Closed
Conversation
Member
|
Duplicate of #6153 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
PyQt5 requirement disables users from using PyQt6
I tried to check PyQt more generally but noticed the following things:
pip install .will build the wheel in a separate isolated process and will not see whether PyQt is in the requirement (so PyQt will always be installed independently from the environment)pip install orange3installs from wheels that always have pyqt5 requirements inside (and setup.py is not there)So checking whether PyQt is installed or not does make sense. PyQt will always be put in dependencies.
Description of changes
To avoid confusion in Conda environments (having PyQt both from PyPi and conda), I am removing this dependency.
Includes