[ENH] Lazy signals for Hierarchical Clustering#6348
[ENH] Lazy signals for Hierarchical Clustering#6348markotoplak merged 4 commits intobiolab:masterfrom
Conversation
janezd
changed the title
|
@janezd, could you rebase this? Also, biolab/orange-widget-base/pull/238 was released in widget-base 4.21.0, so if we change requirements, this PR can be merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6348 +/- ##
=======================================
Coverage 87.68% 87.69%
=======================================
Files 321 321
Lines 69406 69429 +23
=======================================
+ Hits 60859 60885 +26
+ Misses 8547 8544 -3 |
markotoplak
changed the title
| def missing_values(value): | ||
| if value: | ||
| return f'({value*100:.1f}% missing values)' | ||
| return f' ({value*100:.1f}% missing values)' |
There was a problem hiding this comment.
I assume no one calls this externally, and moving a space inside won't be a problem. But I am curious why did you do so.
There was a problem hiding this comment.
Because of space-nazism. We had f'Features: {features} {features_missing}' where features_missing could be an empty string, resulting in a space at the end of the line. I wouldn't be able to sleep knowing that.
markotoplak
force-pushed
the
lazy-signals
branch
from
3f4df37 to
2fc2717
Compare
2 participants
Issue
Ref. #5720.
Includes