Skip to content

[FIX] owpredictions: Fix a type error in report when using NoopDelegate #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janezd merged 1 commit into from
Aug 17, 2023
Merged

[FIX] owpredictions: Fix a type error in report when using NoopDelegate #6537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Orange/widgets/evaluate/owpredictions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import numpy
from AnyQt.QtWidgets import (
QTableView, QSplitter, QToolTip, QStyle, QApplication, QSizePolicy,
QPushButton, QAbstractItemDelegate)
QPushButton, QStyledItemDelegate)
from AnyQt.QtGui import QPainter, QStandardItem, QPen, QColor, QBrush
from AnyQt.QtCore import (
Qt, QSize, QRect, QRectF, QPoint, QPointF, QLocale,
Expand Down Expand Up @@ -1117,14 +1117,16 @@ def sizeHint(cls, option, index):
return cls.__size_hint


class NoopItemDelegate(QAbstractItemDelegate):
class NoopItemDelegate(QStyledItemDelegate):
def paint(self, *_):
pass

@staticmethod
def sizeHint(*_):
def sizeHint(self, *_):
return QSize(0, 0)

def displayText(self, *_):
return ""


class ClassificationErrorDelegate(ErrorDelegate):
def displayText(self, value, _):
Expand Down
8 changes: 8 additions & 0 deletions Orange/widgets/evaluate/tests/test_owpredictions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,14 @@ def test_no_class_on_test(self):
predmodel.data(predmodel.index(0, 0), Qt.UserRole)))
self.assertIn(predmodel.data(predmodel.index(0, 0))[0],
titanic.domain.class_var.values)
self.widget.send_report()

housing = self.housing[::5]
mean_housing = ConstantLearner()(housing)
no_target = housing.transform(Domain(housing.domain.attributes, None))
self.send_signal(self.widget.Inputs.data, no_target)
self.send_signal(self.widget.Inputs.predictors, mean_housing, 1)
self.widget.send_report()

def test_invalid_regression_target(self):
widget = self.widget
Expand Down