Skip to content

[FIX] Fix impute.Model for derived domains#6668

Merged
markotoplak merged 3 commits intobiolab:masterfrom
markotoplak:fix-impute-model
Dec 8, 2023
Merged

[FIX] Fix impute.Model for derived domains#6668
markotoplak merged 3 commits intobiolab:masterfrom
markotoplak:fix-impute-model

Conversation

@markotoplak
Copy link
Member

@markotoplak markotoplak commented Dec 7, 2023

Issue

Found at #6644, but per @VesnaT's comment does not fix it because another check fails.
Fixes #6644 (after @VesnaT's commit).

Description of changes

The compute_value was missing transformation into the variable space it was working upon.

Thanks to @VesnaT for providing minimum code that reproduced the error.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak markotoplak force-pushed the fix-impute-model branch 2 times, most recently from 53429a2 to 53bbd08 Compare December 7, 2023 15:54
The compute_value was missing transformation into the variable space it
was working upon.
@VesnaT
Copy link
Contributor

VesnaT commented Dec 8, 2023

The fix does not prevent the Prediction error message, it only changes it.

image

@markotoplak
Copy link
Member Author

@VesnaT, thanks. I removed the "fixes" statement in the issue description, but think that this is still a step forward and that this PR should be merged.

@codecov
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #6668 (3752aea) into master (e5ceec7) will decrease coverage by 0.01%.
Report is 10 commits behind head on master.
The diff coverage is 88.88%.

❗ Current head 3752aea differs from pull request most recent head 0547537. Consider uploading reports for the commit 0547537 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6668      +/-   ##
==========================================
- Coverage   88.10%   88.10%   -0.01%     
==========================================
  Files         321      321              
  Lines       69946    69950       +4     
==========================================
+ Hits        61628    61629       +1     
- Misses       8318     8321       +3     

@markotoplak markotoplak merged commit ef3465d into biolab:master Dec 8, 2023
@markotoplak markotoplak deleted the fix-impute-model branch July 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

predictions displaying error that the target is not in domain

3 participants