Skip to content

[FIX] CSV Import: Add explicit datetime conversion #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrimozGodec merged 2 commits into from
Jan 15, 2024
Merged

[FIX] CSV Import: Add explicit datetime conversion #6696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a7bc6c
owcsvimport: Remove workaround for pandas issue 35365
ales-erjavec Jan 5, 2024
0bed791
owcsvimport: Add explicit to_datetime conversion
ales-erjavec Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Orange/widgets/data/owcsvimport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,11 +1532,6 @@ def expand(ranges):
numbers_format_kwds["thousands"] = opts.group_separator

if numbers_format_kwds:
# float_precision = "round_trip" cannot handle non c-locale decimal and
# thousands sep (https://github.com/pandas-dev/pandas/issues/35365).
# Fallback to 'high'.
numbers_format_kwds["float_precision"] = "high"
else:
numbers_format_kwds["float_precision"] = "round_trip"

with ExitStack() as stack:
Expand All @@ -1559,7 +1554,12 @@ def expand(ranges):
na_values=na_values, keep_default_na=False,
**numbers_format_kwds
)

if parse_dates:
for date_col in parse_dates:
if df.dtypes[date_col] == "object":
df[df.columns[date_col]] = pd.to_datetime(
df.iloc[:, date_col], errors="coerce"
)
if prefix:
df.columns = [f"{prefix}{column}" for column in df.columns]

Expand Down