[FIX] test_owcsvimport: Workaround for segfault in tests on macos#6735
Merged
PrimozGodec merged 1 commit intobiolab:masterfrom Feb 29, 2024
Merged
Conversation
Explicitly schedule the deletion of QFileDialog before the parent widget.
5b1df1e to
febf466
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6735 +/- ##
==========================================
- Coverage 88.14% 88.13% -0.01%
==========================================
Files 322 322
Lines 70589 70589
==========================================
- Hits 62220 62216 -4
- Misses 8369 8373 +4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
test_owcsvimport tests sometimes segfault in CI tests.
Specifically this almost always happens in the installer tests.
When build against this branch the installer tests seem to pass
Description of changes
Explicitly schedule the deletion of QFileDialog before the parent widget.
Includes