[FIX] Edit Domain: Partial restore state on categories mismatch#6776
Merged
markotoplak merged 4 commits intobiolab:masterfrom May 24, 2024
Merged
[FIX] Edit Domain: Partial restore state on categories mismatch#6776markotoplak merged 4 commits intobiolab:masterfrom
markotoplak merged 4 commits intobiolab:masterfrom
Conversation
ales-erjavec
force-pushed
the
oweditdomain-restore-state
branch
from
9e593fe to
1770def
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6776 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 327 327
Lines 71318 71346 +28
=======================================
+ Hits 62926 62953 +27
- Misses 8392 8393 +1 |
janezd
reviewed
May 13, 2024
Ignore categories when exact match for a variable is not found in the stored settings (i.e. match by name and type only). If a stored transform is a `CategoriesMapping` transform that does not match the input, then it is dropped and a warning is shown.
markotoplak
force-pushed
the
oweditdomain-restore-state
branch
from
5315d49 to
62e1f31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: gh-6660
Description of changes
CategoriesMappingtransform that does not match the input, then it is dropped and a warning is shown.Includes