test_owcurvefit: fix testing failure on conda#6928
Merged
markotoplak merged 1 commit intobiolab:masterfrom Nov 15, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6928 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 329 329
Lines 72480 72544 +64
=======================================
+ Hits 64069 64128 +59
- Misses 8411 8416 +5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I saw the follwing with conda scipy from conda (first noticed in biolab/orange3-installers#55 (comment)):
Description of changes
test_expressionlooped through all possible functions, and some of them produce objective function values with NaNs.Different implementations of optimization that scipy uses get different results: one stops optimization immediately with some results, the other stops when maximum number of iterations (and errors with fitting_failed). The optimization implementation can be different even with the same scipy version (in my case, between pypi and conda-forge package). Thus, we skip these.
Includes