[FIX] Orange can be imported without Qt (fixed importing localization)#6955
Merged
markotoplak merged 2 commits intobiolab:masterfrom Dec 16, 2024
Merged
[FIX] Orange can be imported without Qt (fixed importing localization)#6955markotoplak merged 2 commits intobiolab:masterfrom
markotoplak merged 2 commits intobiolab:masterfrom
Conversation
Member
|
I tested these two PR (installed, so translated, at first I forgot about this) and they did fix the reported issue for me . But then, when testing, if I only remove pyqt* in my environment, I still get complains from Orange's I also had to remove AnyQt for them to disappear. Did you have to do that too? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6955 +/- ##
==========================================
+ Coverage 88.45% 88.47% +0.01%
==========================================
Files 331 332 +1
Lines 73099 73277 +178
==========================================
+ Hits 64659 64831 +172
- Misses 8440 8446 +6 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6952. Requires biolab/orange-canvas-core#320 to be merged and released.
Description of changes
Import localization from a place that doesn't require Qt.
The most important change is the one in configuration of Trubar - this will allow running Orange without Qt.
The other two changes in
[Orange/widgets/utils/localization/__init__.py](https://github.com/biolab/orange3/compare/master...janezd:fix-headless-orange?expand=1#diff-3bf6fd4d089b6924794714d11768d90dbac35b1b370e9cfc788c6cd6f216eece)are not strictly necessary, but prevent a warning about importing localization from a deprecated module.Includes