Skip to content

[FIX] 1 line headers: only allow single-letter types and flags#6959

Merged
markotoplak merged 2 commits intobiolab:masterfrom
markotoplak:1header-fix
Dec 20, 2024
Merged

[FIX] 1 line headers: only allow single-letter types and flags#6959
markotoplak merged 2 commits intobiolab:masterfrom
markotoplak:1header-fix

Conversation

@markotoplak
Copy link
Member

Issue

Fixes #6945

Description of changes

This fix creates specific 1-line header matching rules (does not reuse the 3-line header ones).

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (f70085b) to head (a32263a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6959   +/-   ##
=======================================
  Coverage   88.47%   88.48%           
=======================================
  Files         332      332           
  Lines       73280    73287    +7     
=======================================
+ Hits        64834    64847   +13     
+ Misses       8446     8440    -6     

@janezd
Copy link
Contributor

janezd commented Dec 20, 2024

I named the groups. Otherwise OK; merge if you agree with my changes.

@markotoplak
Copy link
Member Author

Thanks, naming groups is nice!

@markotoplak markotoplak merged commit 9fb3969 into biolab:master Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems with Excel/csv reader in Orange 3.38

2 participants