Skip to content

[FIX] io_util: Detect utf-8-sig when using file utility#7006

Merged
janezd merged 1 commit intobiolab:masterfrom
ales-erjavec:table-reader-utf-8-sig
Feb 7, 2025
Merged

[FIX] io_util: Detect utf-8-sig when using file utility#7006
janezd merged 1 commit intobiolab:masterfrom
ales-erjavec:table-reader-utf-8-sig

Conversation

@ales-erjavec
Copy link
Contributor

Issue

Detect utf-8-sig when using file utility.

Fixes #7000

Note: An alternative would be to remove the use of file utility, chardet would recognize the BOM (and does so on windows where file is typically not available).

Description of changes

Detect utf-8-sig when using file utility.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (091e88c) to head (2df43bf).
Report is 65 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7006   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         332      332           
  Lines       73333    73341    +8     
=======================================
+ Hits        64889    64897    +8     
  Misses       8444     8444           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ales-erjavec ales-erjavec force-pushed the table-reader-utf-8-sig branch from 2fd00d0 to a714864 Compare January 29, 2025 09:07
@ales-erjavec ales-erjavec force-pushed the table-reader-utf-8-sig branch from a714864 to 2df43bf Compare January 29, 2025 09:35
@janezd janezd self-assigned this Feb 7, 2025
@janezd janezd merged commit c72c463 into biolab:master Feb 7, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSV files containing BOM get that invisibly tacked onto first column name

2 participants