Skip to content

[FIX] ScoringSheet deterministic results#7023

Merged
markotoplak merged 2 commits intobiolab:masterfrom
ZanMervic:bugfix/6924/reproducible-scoring-sheets
Feb 12, 2025
Merged

[FIX] ScoringSheet deterministic results#7023
markotoplak merged 2 commits intobiolab:masterfrom
ZanMervic:bugfix/6924/reproducible-scoring-sheets

Conversation

@ZanMervic
Copy link
Contributor

Issue

Fixes #6924

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Member

Oh, that was where the randomness was coming from? Thanks!

Could you also make a test which tests for actual parameter value (hardcoded in the tests)?

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (7be875f) to head (92d1778).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7023      +/-   ##
==========================================
- Coverage   88.36%   88.36%   -0.01%     
==========================================
  Files         332      332              
  Lines       73345    73345              
==========================================
- Hits        64813    64809       -4     
- Misses       8532     8536       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@markotoplak markotoplak merged commit e67650f into biolab:master Feb 12, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scoring sheets model is not reproducible

2 participants