[FIX] ScoringSheetViewer slider style and tooltip#7024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7024 +/- ##
==========================================
+ Coverage 88.36% 88.60% +0.24%
==========================================
Files 332 332
Lines 73345 73384 +39
==========================================
+ Hits 64813 65025 +212
+ Misses 8532 8359 -173 🚀 New features to boost your workflow:
|
|
I like the change visually, but the tooltip doesn't work for me. Perhaps it is not necessary, since we see the exact probability below, but I kind like tooltips in general. |
| # Draw a simple 2px wide black rectangle as the custom handle. | ||
| painter.save() | ||
| painter.setPen(Qt.NoPen) | ||
| painter.setBrush(Qt.black) |
There was a problem hiding this comment.
Use
painter.setBrush(QPalette().color(QPalette.WindowText))
to support dark mode.
| painter.save() | ||
| painter.setPen(Qt.NoPen) | ||
| painter.setBrush(Qt.black) | ||
| painter.drawRect(QRect(handle_rect.center().x() - 1, handle_rect.y(), 4, handle_rect.height())) |
There was a problem hiding this comment.
This hard rectangle looks Linux-y. Perhaps change to this?
painter.drawRoundedRect(QRect(handle_rect.center().x() - 1, handle_rect.y(),
3, handle_rect.height()),
3, 3)
|
@ZanMervic, thanks for the change. Apologies that it took me so long to review this. I made the slider a tad shorter, I think it looks nicer. Lint failed with a complaint about accessing a private method, so I looked in. The problem is that the code didn't follow the proper Qt way for the widget to update a parent, which is by emitting a signal. I made the necessary change. Please check and -- if it's OK -- merge (or approve if you have no right to merge). |
3e3cd4b to
2b517e7
Compare
Issue
Fixes #6985
Description of changes
Includes