Skip to content

[FIX] ScoringSheetViewer computing target class values from base values#7025

Merged
VesnaT merged 2 commits intobiolab:masterfrom
ZanMervic:bugfix/6996/use-base-values-on-target-switch
May 23, 2025
Merged

[FIX] ScoringSheetViewer computing target class values from base values#7025
VesnaT merged 2 commits intobiolab:masterfrom
ZanMervic:bugfix/6996/use-base-values-on-target-switch

Conversation

@ZanMervic
Copy link
Contributor

Issue

Fixes #6996

Description of changes
  • Refactors the ScoringSheetViewer widget so the displayed values are computed from base values which never change.
  • Sorts the attributes by importance (absolute value of coefficients), so the most important attributes are displayed on top.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (7be875f) to head (67f6d2d).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7025      +/-   ##
==========================================
+ Coverage   88.36%   88.62%   +0.25%     
==========================================
  Files         332      332              
  Lines       73345    73381      +36     
==========================================
+ Hits        64813    65034     +221     
+ Misses       8532     8347     -185     

@janezd janezd self-assigned this Feb 14, 2025
@ZanMervic ZanMervic force-pushed the bugfix/6996/use-base-values-on-target-switch branch from f79ef51 to 67f6d2d Compare March 1, 2025 00:58
@janezd
Copy link
Contributor

janezd commented Apr 26, 2025

I simplified the initialization of coefficients from data -- some lines probably remained from the way it was implemented before. Can someone (@ZanMervic or @VesnaT) check it? Thanks!

@janezd janezd assigned VesnaT and unassigned janezd May 22, 2025
@VesnaT VesnaT merged commit 3c36b1c into biolab:master May 23, 2025
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scoring Sheet Viewer: Refactor

3 participants