Skip to content

[FIX] Disable dynamic signals where applicable#7045

Merged
ajdapretnar merged 1 commit intobiolab:masterfrom
ales-erjavec:specific-output-types
Mar 14, 2025
Merged

[FIX] Disable dynamic signals where applicable#7045
ajdapretnar merged 1 commit intobiolab:masterfrom
ales-erjavec:specific-output-types

Conversation

@ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Mar 7, 2025

Issue

Ref: #7043

CSV Import in particular should not have declared dynamic output.

Description of changes

Disable dynamic outputs where applicable.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (afc6c18) to head (f0fe384).
Report is 64 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7045      +/-   ##
==========================================
- Coverage   88.62%   88.61%   -0.01%     
==========================================
  Files         332      332              
  Lines       73365    73365              
==========================================
- Hits        65019    65015       -4     
- Misses       8346     8350       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Orange.data.Table,
replaces=["Merged Data A+B", "Merged Data B+A", "Merged Data"])
replaces=["Merged Data A+B", "Merged Data B+A", "Merged Data"],
dynamic=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I'm unsure of. Could I not merge two corpora? I do this often (append metadata to a corpus).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can gather this will always create a plain Table
https://github.com/biolab/orange3/blob/3.38.1/Orange/widgets/data/owmergedata.py#L630-L632

        table = Orange.data.Table.from_numpy(domain, X, Y, metas)
        table.name = getattr(self.data, 'name', '')
        table.attributes = getattr(self.data, 'attributes', {})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we might have discussed this with Primož at some point and agreed it should be a Table.

@ajdapretnar ajdapretnar merged commit 6b32698 into biolab:master Mar 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants