[FIX] Disable dynamic signals where applicable#7045
Merged
ajdapretnar merged 1 commit intobiolab:masterfrom Mar 14, 2025
Merged
[FIX] Disable dynamic signals where applicable#7045ajdapretnar merged 1 commit intobiolab:masterfrom
ajdapretnar merged 1 commit intobiolab:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7045 +/- ##
==========================================
- Coverage 88.62% 88.61% -0.01%
==========================================
Files 332 332
Lines 73365 73365
==========================================
- Hits 65019 65015 -4
- Misses 8346 8350 +4 🚀 New features to boost your workflow:
|
ajdapretnar
reviewed
Mar 14, 2025
| Orange.data.Table, | ||
| replaces=["Merged Data A+B", "Merged Data B+A", "Merged Data"]) | ||
| replaces=["Merged Data A+B", "Merged Data B+A", "Merged Data"], | ||
| dynamic=False) |
Contributor
There was a problem hiding this comment.
This one I'm unsure of. Could I not merge two corpora? I do this often (append metadata to a corpus).
Contributor
Author
There was a problem hiding this comment.
From what I can gather this will always create a plain Table
https://github.com/biolab/orange3/blob/3.38.1/Orange/widgets/data/owmergedata.py#L630-L632
table = Orange.data.Table.from_numpy(domain, X, Y, metas)
table.name = getattr(self.data, 'name', '')
table.attributes = getattr(self.data, 'attributes', {})
Contributor
There was a problem hiding this comment.
Right, we might have discussed this with Primož at some point and agreed it should be a Table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ref: #7043
CSV Import in particular should not have declared dynamic output.
Description of changes
Disable dynamic outputs where applicable.
Includes