Skip to content

[FIX] Update check and notifications: avoid compression#7097

Merged
markotoplak merged 2 commits intobiolab:masterfrom
markotoplak:fix-update-error
Jun 11, 2025
Merged

[FIX] Update check and notifications: avoid compression#7097
markotoplak merged 2 commits intobiolab:masterfrom
markotoplak:fix-update-error

Conversation

@markotoplak
Copy link
Member

Issue

Update check failed for me because the response was compresses, and urllib (if I understand it) does not decompress it automatically.

2025-06-02 13:30:08,020:ERROR:Orange.canvas.__main__: Failed to check for updates Traceback (most recent call last):
  File "/home/marko/dev/orange3/Orange/canvas/__main__.py", line 97, in run
    contents = urlopen(request, timeout=10).read().decode()
Description of changes

Force identity encoding.

Includes
  • Code changes
  • Tests
  • Documentation

2025-06-02 13:30:08,020:ERROR:Orange.canvas.__main__: Failed to check for updates
Traceback (most recent call last):
  File "/home/marko/dev/orange3/Orange/canvas/__main__.py", line 97, in run
    contents = urlopen(request, timeout=10).read().decode()
@markotoplak markotoplak added this to the 3.39 milestone Jun 2, 2025
@markotoplak
Copy link
Member Author

There is other place in orange3 code base where we could get a similar problem: in UrlReader. Does anyone remember any problems with it?

Here, I think we had a bug because we even requested a gzip, and the server happily started obliging. But I am not sure what is the default value of 'Accept-Encoding' in urllib and how is that handled on servers.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@66928eb). Learn more about missing BASE report.
⚠️ Report is 96 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7097   +/-   ##
=========================================
  Coverage          ?   88.71%           
=========================================
  Files             ?      332           
  Lines             ?    73396           
  Branches          ?        0           
=========================================
  Hits              ?    65114           
  Misses            ?     8282           
  Partials          ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@markotoplak
Copy link
Member Author

If this was the problem, users will not be notified of a new version.

@lanzagar suggested setting the server not to compress, if this is possible (this goes through Cloudflare).

@markotoplak markotoplak merged commit ba72a1b into biolab:master Jun 11, 2025
20 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant