[FIX] Update check and notifications: avoid compression#7097
[FIX] Update check and notifications: avoid compression#7097markotoplak merged 2 commits intobiolab:masterfrom
Conversation
2025-06-02 13:30:08,020:ERROR:Orange.canvas.__main__: Failed to check for updates
Traceback (most recent call last):
File "/home/marko/dev/orange3/Orange/canvas/__main__.py", line 97, in run
contents = urlopen(request, timeout=10).read().decode()
|
There is other place in Here, I think we had a bug because we even requested a gzip, and the server happily started obliging. But I am not sure what is the default value of 'Accept-Encoding' in urllib and how is that handled on servers. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7097 +/- ##
=========================================
Coverage ? 88.71%
=========================================
Files ? 332
Lines ? 73396
Branches ? 0
=========================================
Hits ? 65114
Misses ? 8282
Partials ? 0 🚀 New features to boost your workflow:
|
|
If this was the problem, users will not be notified of a new version. @lanzagar suggested setting the server not to compress, if this is possible (this goes through Cloudflare). |
Issue
Update check failed for me because the response was compresses, and
urllib(if I understand it) does not decompress it automatically.Description of changes
Force
identityencoding.Includes