Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7107 +/- ##
==========================================
- Coverage 88.73% 88.73% -0.01%
==========================================
Files 332 332
Lines 73450 73455 +5
==========================================
+ Hits 65176 65177 +1
- Misses 8274 8278 +4 🚀 New features to boost your workflow:
|
VesnaT
reviewed
Jun 13, 2025
| return | ||
|
|
||
| if self.data is None: | ||
| if self.data.X is None or self.data.X.shape[1] == 0: |
Contributor
There was a problem hiding this comment.
I think self.data.X is None could never be True.
Table.X is always a np.ndarray, but sometimes empty.
Contributor
Author
There was a problem hiding this comment.
I thought as much. Thanks for checking!
| self.Error.no_features() | ||
| self.data = None | ||
| self.Outputs.annotated_data.send(None) | ||
| self.plot.clear_plot() |
Contributor
There was a problem hiding this comment.
To avoid the duplicated code, I'd rather the code was places right after the
if not self.check_data_size(data):
data = None
block, and implemented similarly (not necessarily with an additional function, but by setting the data to None before assigning it to self.data). In this case self.data_normalized would also be properly set.
7d6d8d2 to
da6e7ef
Compare
Contributor
Author
|
@VesnaT Fixed, you can check again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7105.
Description of changes
Handle empty X (often from plain Corpus).
Includes