Skip to content

[FIX] CSV Import: Fix non-functioning encodings selection#7181

Merged
lanzagar merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/csvimport-encodings
Nov 7, 2025
Merged

[FIX] CSV Import: Fix non-functioning encodings selection#7181
lanzagar merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/csvimport-encodings

Conversation

@ales-erjavec
Copy link
Contributor

Issue

CSV Import's Customize Encodings List... does not work on PyQt6. Always clears all except ASCII

Description of changes

Fix check condition due to type mismatch

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.91%. Comparing base (c0c64d6) to head (3f5271a).
⚠️ Report is 148 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7181      +/-   ##
==========================================
+ Coverage   88.82%   88.91%   +0.09%     
==========================================
  Files         335      335              
  Lines       73970    73970              
==========================================
+ Hits        65701    65771      +70     
+ Misses       8269     8199      -70     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lanzagar lanzagar merged commit f192ae9 into biolab:master Nov 7, 2025
20 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants