-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
git push origin fix-futurewarning-table-to-frame-v2 #7222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
git push origin fix-futurewarning-table-to-frame-v2 #7222
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7222 +/- ##
==========================================
- Coverage 89.03% 89.03% -0.01%
==========================================
Files 335 335
Lines 74243 74243
==========================================
- Hits 66102 66101 -1
- Misses 8141 8142 +1 🚀 New features to boost your workflow:
|
|
Thanks for the update! I see that one CI check is failing on macOS (py3.12). Happy to update the PR if needed. |
|
@varshithreddy39 , thank you for this PR. The failing test doesn't look related to your changes. I haven't seen this failure yet; we'll see whether it reappears on the next run. The proposed fix doesn't work, though. The warning still shows in this place and in one other (see the logs below). My experience with pandas is inadequate, but I think that the problem is before This removes the warning and doesn't seem to break anything. Please do the following.
Thanks again! |
This PR fixes a pandas FutureWarning triggered in table_to_frame
when handling discrete variables by following pandas'
recommended infer_objects(copy=False) usage.
Closes #7063.