Conversation
| """ | ||
| return self._get_meta_prop(nid, 'definition') | ||
|
|
||
| def definition_val(self, nid): |
There was a problem hiding this comment.
This seems like this should just be a method on whatever is returned from self.definition. So if you want the string version, you would just say str(definition(id)) instead of providing a separate method here.
There was a problem hiding this comment.
the most common operation is getting the value; but in any case this will be dropped as I accidentlly reimplemented this code on a separate PR that's already been merged, doh
There was a problem hiding this comment.
Oh it's merged already? Where at? I was thinking we would release after this PR to get my logging changes in and this.
Oh, I just saw that it's just a dictionary that's being returned and not a real Object. I guess my suggestion doesn't make as much sense then.
|
NOTE: it's likely this will end up living in a different repo |
2 participants
No description provided.