fix: refactor LSP server descriptor to handle multiple roots

sandbox/bar/package.json

@@ -3,7 +3,7 @@
   "private": true,
   "packageManager": "[email protected]",
   "devDependencies": {
-    "@biomejs/biome": "2.0.0-beta.1"
+    "@biomejs/biome": "2.0.0-beta.3"
   },
   "scripts": {
     "check": "biome check"

sandbox/foo/package.json

@@ -3,7 +3,7 @@
   "private": true,
   "packageManager": "[email protected]",
   "devDependencies": {
-    "@biomejs/biome": "2.0.0-beta.1"
+    "@biomejs/biome": "2.0.0-beta.3"
   },
   "scripts": {
     "check": "biome check"

sandbox/foo/src/subdir/biome.jsonc

@@ -0,0 +1,11 @@
+{
+  "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+  "linter": {
+    "rules": {
+      "recommended": true,
+      "style": {
+        "useConst": "error"
+      }
+    }
+  }
+}

sandbox/foo/src/subdir/index.js

@@ -0,0 +1,3 @@
+let a = 1;
+let b = 2;
+let foo = a == b;

sandbox/food/biome.jsonc

@@ -0,0 +1,8 @@
+{
+  "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+  "linter": {
+    "rules": {
+      "recommended": true
+    }
+  }
+}

sandbox/food/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "@biome-intellij-sandbox/foo",
+  "private": true,
+  "packageManager": "[email protected]",
+  "devDependencies": {
+    "@biomejs/biome": "2.0.0-beta.1"
+  },
+  "scripts": {
+    "check": "biome check"
+  }
+}

sandbox/food/src/index.js

@@ -0,0 +1,3 @@
+let a = 1;
+let b = 2;
+let foo = a == b;

sandbox/pnpm-workspace.yaml

@@ -1,3 +1,4 @@
 packages:
   - foo
   - bar
+  - food

src/main/kotlin/com/github/biomejs/intellijbiome/BiomeConfig.kt

@@ -0,0 +1,14 @@
+package com.github.biomejs.intellijbiome
+
+import com.intellij.openapi.vfs.VirtualFile
+
+object BiomeConfig {
+    const val baseName = "biome"
+    val validExtensions = listOf("json", "jsonc")
+
+    val validFileNames: Set<String> = validExtensions.map { "$baseName.$it" }.toSet()
+
+    fun isBiomeConfigFile(file: VirtualFile?): Boolean {
+        return file != null && validFileNames.contains(file.name)
+    }
+}

src/main/kotlin/com/github/biomejs/intellijbiome/BiomePackage.kt

@@ -18,27 +18,12 @@ class BiomePackage(private val project: Project) {
     private val packageName = "@biomejs/biome"
     private val packageDescription = NodePackageDescriptor(packageName)
 
-    fun getPackage(virtualFile: VirtualFile?): NodePackage? {
-        if (virtualFile != null) {
-            val available = packageDescription.listAvailable(
-                project,
-                NodeJsInterpreterManager.getInstance(project).interpreter,
-                virtualFile,
-                false,
-                true
-            )
-            if (available.isNotEmpty()) {
-                return available[0]
-            }
-        }
-
-        var pkg = packageDescription.findUnambiguousDependencyPackage(project) ?: NodePackage.findDefaultPackage(
-            project,
-            packageName,
-            NodeJsInterpreterManager.getInstance(project).interpreter
-        )
-
-        return pkg
+    fun getPackage(contextFileOrDirectory: VirtualFile?): NodePackage? {
+        val interpreter = NodeJsInterpreterManager.getInstance(project).interpreter
+        val listAvailable = packageDescription.listAvailable(project, interpreter, contextFileOrDirectory, false, true)
+        return listAvailable.firstOrNull()
+            ?: packageDescription.findUnambiguousDependencyPackage(project)
+            ?: NodePackage.findDefaultPackage(project, packageName, interpreter)
     }
 
     fun configPath(): String? {
@@ -61,24 +46,20 @@ class BiomePackage(private val project: Project) {
         }
     }
 
-    fun binaryPath(
-        configPath: String?,
-        virtualFile: VirtualFile,
-        showVersion: Boolean,
-    ): String? {
+    fun binaryPath(virtualFile: VirtualFile?): String? {
         val settings = BiomeSettings.getInstance(project)
         val configurationMode = settings.configurationMode
         return when (configurationMode) {
             ConfigurationMode.DISABLED -> null // don't try to find the executable path if the configuration file does not exist.
             // This will prevent start LSP and formatting in case if biome is not used in the project.
-            ConfigurationMode.AUTOMATIC -> if (configPath != null || showVersion) findBiomeExecutable(virtualFile) else null // if configuration mode is manual, return the executable path if it is not empty string.
+            ConfigurationMode.AUTOMATIC -> findBiomeExecutable(virtualFile) // if configuration mode is manual, return the executable path if it is not empty string.
             // Otherwise, try to find the executable path.
             ConfigurationMode.MANUAL -> settings.executablePath
         }
     }
 
-    private fun findBiomeExecutable(virtualFile: VirtualFile?): String? {
-        val path = getPackage(virtualFile)?.getAbsolutePackagePathToRequire(project)
+    private fun findBiomeExecutable(contextFileOrDirectory: VirtualFile?): String? {
+        val path = getPackage(contextFileOrDirectory)?.getAbsolutePackagePathToRequire(project)
         if (path != null) {
             return Paths.get(path, "bin/biome").toString()
         }
@@ -92,12 +73,8 @@ class BiomePackage(private val project: Project) {
             return null
         }
 
-        val processHandler =
-            BiomeTargetRunBuilder(project)
-                .getBuilder(binaryPath)
-                .addParameters(listOf(ProcessCommandParameter.Value("--version")))
-                .build()
-                .startProcess()
+        val processHandler = BiomeTargetRunBuilder(project).getBuilder(binaryPath)
+            .addParameters(listOf(ProcessCommandParameter.Value("--version"))).build().startProcess()
 
         return runCatching {
             val result = runProcessFuture(processHandler).await()

src/main/kotlin/com/github/biomejs/intellijbiome/actions/BiomeApplySafeFixesAction.kt

@@ -3,9 +3,9 @@ package com.github.biomejs.intellijbiome.actions
 import com.github.biomejs.intellijbiome.BiomeBundle
 import com.github.biomejs.intellijbiome.BiomeIcons
 import com.github.biomejs.intellijbiome.services.BiomeServerService
-import com.github.biomejs.intellijbiome.services.BiomeServerService.Feature
 import com.github.biomejs.intellijbiome.settings.BiomeConfigurable
 import com.github.biomejs.intellijbiome.settings.BiomeSettings
+import com.github.biomejs.intellijbiome.settings.Feature
 import com.intellij.notification.NotificationAction
 import com.intellij.notification.NotificationGroupManager
 import com.intellij.notification.NotificationType

src/main/kotlin/com/github/biomejs/intellijbiome/actions/BiomeSortImportAction.kt

@@ -3,7 +3,7 @@ package com.github.biomejs.intellijbiome.actions
 import com.github.biomejs.intellijbiome.BiomeBundle
 import com.github.biomejs.intellijbiome.BiomeIcons
 import com.github.biomejs.intellijbiome.services.BiomeServerService
-import com.github.biomejs.intellijbiome.services.BiomeServerService.Feature
+import com.github.biomejs.intellijbiome.settings.Feature
 import com.github.biomejs.intellijbiome.settings.BiomeConfigurable
 import com.github.biomejs.intellijbiome.settings.BiomeSettings
 import com.intellij.notification.NotificationAction

src/main/kotlin/com/github/biomejs/intellijbiome/extensions/CapturingProcessAdapterExt.kt

@@ -6,7 +6,7 @@ import com.intellij.execution.process.ProcessEvent
 import com.intellij.execution.process.ProcessOutput
 import java.util.concurrent.CompletableFuture
 
-class ProcessResult( val processOutput: ProcessOutput)
+class ProcessResult(val processOutput: ProcessOutput)
 
 
 fun runProcessFuture(handler: OSProcessHandler): CompletableFuture<ProcessResult> {