fix(locator): fix pnpm path in globalNodeModulesPaths and optimize error handling#760
Open
axuj wants to merge 2 commits intobiomejs:mainfrom
Open
fix(locator): fix pnpm path in globalNodeModulesPaths and optimize error handling#760axuj wants to merge 2 commits intobiomejs:mainfrom
axuj wants to merge 2 commits intobiomejs:mainfrom
Conversation
…ror handling - Add shell: true option to safeSpawnSync calls to fix pnpm path - Modify error handling logic to use continue instead of return to continue searching other paths
Member
|
Thanks! |
nhedger
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed pnpm path resolution issue on Windows and improved error handling in global node modules path detection.
Description
This PR addresses a critical issue where spawnSync('npm') fails to execute properly on Windows environments when the shell option is not explicitly set to true. The problem manifests in the globalNodeModulesPaths function where path resolution for pnpm fails due to improper command execution.
Changes made:
A test case was used to verify the issue:
This change ensures cross-platform compatibility and more robust error handling for node modules path detection.
Related Issue
This PR closes #<issue_number>
Checklist