fix(lint): treat Astro Image component like img in useAnchorContent#9270
fix(lint): treat Astro Image component like img in useAnchorContent#9270kbo4sho wants to merge 1 commit intobiomejs:mainfrom
Conversation
Resolves biomejs#9210 The useAnchorContent rule now recognizes Astro's built-in Image component (from astro:assets) and treats it the same as the native img element, checking for the alt attribute as valid accessible content. This prevents false positives when using the Image component inside anchor tags with proper alt text.
|
github-actions
bot
added
A-Linter
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
WalkthroughThe Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Changeset missing. Wrong implement. Not enough tests.
|
|
||
| match tag_text.as_ref().map(|t| t.as_ref()) { | ||
| Some(name) if name.eq_ignore_ascii_case("img") => { | ||
| Some(name) if name.eq_ignore_ascii_case("img") || name == "Image" => { |
There was a problem hiding this comment.
That's wrong.
Your PR says it checks for the Astro Image component. This checks for EVERY component, without discrimination.
2 participants
🤖 AI Disclosure: This PR was authored by an AI agent (OpenClaw) on behalf of @kbo4sho. Happy to address feedback.
Summary
Fixes #9210
The
useAnchorContentrule was throwing a false positive when using Astro's built-in<Image>component inside anchor tags, even when the component had a validaltattribute.This PR adds recognition for the Astro
Imagecomponent (fromastro:assets) and treats it the same as the native<img>element - checking for thealtattribute as valid accessible content.Changes
has_accessible_contentto recognize bothimg(case-insensitive) andImage(exact match for Astro component)<Image>component withaltattribute in valid.astroTest Plan
Added a test case demonstrating that
<a><Image src={profileImg} alt="profile picture" /></a>should be considered valid accessible content, just like<a><img alt="description" /></a>.The fix is minimal and follows the existing pattern for other image-like elements in the codebase.