Skip to content

fix(lint): treat Astro Image component like img in useAnchorContent #9270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kbo4sho wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

fix(lint): treat Astro Image component like img in useAnchorContent #9270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/biome_html_analyze/src/lint/a11y/use_anchor_content.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ fn has_accessible_content(html_child_list: &HtmlElementList) -> bool {
let tag_text = element.name().ok().and_then(|n| n.token_text_trimmed());

match tag_text.as_ref().map(|t| t.as_ref()) {
Some(name) if name.eq_ignore_ascii_case("img") => {
Some(name) if name.eq_ignore_ascii_case("img") || name == "Image" => {
Copy link
Member

@ematipico ematipico Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's wrong.

Your PR says it checks for the Astro Image component. This checks for EVERY component, without discrimination.

html_self_closing_element_has_non_empty_attribute(element, "alt")
}
Some(name)
Expand Down
3 changes: 3 additions & 0 deletions crates/biome_html_analyze/tests/specs/a11y/useAnchorContent/astro/valid.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@
<!-- Accessible via aria-label or title alone -->
<a aria-label="Navigate to dashboard"></a>
<a title="Go to settings page"></a>

<!-- Astro Image component with alt attribute should be treated like img -->
<a><Image src={profileImg} alt="profile picture" /></a>