feat: detected Legacy component lifecycle#128
Open
iamnamananand996 wants to merge 3 commits intobiomejs:mainfrom
Open
feat: detected Legacy component lifecycle#128iamnamananand996 wants to merge 3 commits intobiomejs:mainfrom
iamnamananand996 wants to merge 3 commits intobiomejs:mainfrom
Conversation
morgante
requested changes
Mar 6, 2024
| detected Legacy component lifecycle | ||
| - `componentWillMount` -> `componentDidMount` | ||
| - `componentWillReceiveProps` -> `componentDidUpdate` | ||
| - `componentWillUpdate` -> `componentDidUpdate` |
Collaborator
There was a problem hiding this comment.
These aren't direct replacements, so ideally we have some logic to detect things like when getSnapshotBeforeUpdate should be used. See https://legacy.reactjs.org/docs/react-component.html#unsafe_componentwillupdate.
| @@ -0,0 +1,135 @@ | |||
| --- | |||
| title: Update React legacy component | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| title: Update React legacy component | |
| title: Remove legacy React lifecycle methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detected Legacy component lifecycle
componentWillMount->componentDidMountcomponentWillReceiveProps->componentDidUpdatecomponentWillUpdate->componentDidUpdategrit studio link: https://app.grit.io/studio?key=pmcyLDVyDHERfODgtvwUk