Skip to content

fix: remove incorrect go rule #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morgante wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove incorrect go rule #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .grit/patterns/go/useless_if_else_body.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Identical statements in the if else body
tags: [fix, correctness]
tags: [fix, dead-code]
---

Identical statements found in both the `if` and `else` bodies of an `if-statement`. This results in the same code execution regardless of the if-expression outcome. To optimize, eliminate the `if` statement entirely.
Expand All @@ -9,7 +9,6 @@ Identical statements found in both the `if` and `else` bodies of an `if-statemen
language go

or {
`if ($conditon) { $body } else { $body }`,
`if ($conditon) { $body } else if ($conditon) { $body }`
} => `if ($conditon) {
$body
Expand Down