-
-
Notifications
You must be signed in to change notification settings - Fork 26
feat: add java importing pattern util #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,336 @@ | ||
| --- | ||
| title: import util for java | ||
| tag: [java] | ||
| --- | ||
|
|
||
| # Test remove statement | ||
|
|
||
| ```grit | ||
| language java | ||
| file($body) where { | ||
| $delete_import = "import a.b.Text;", | ||
| $body<: maybe contains remove_import_statement($delete_import) | ||
| } | ||
| ``` | ||
|
|
||
| ## test remove one import statements when there are more than one import statements | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
| import a.b.Form; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Form; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## test remove one import statements when there are only one import statements | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Text text) { | ||
| this.str = text; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Text text) { | ||
| this.str = text; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| # Test ensure_import_statement | ||
|
|
||
| ```grit | ||
| language java | ||
| file($body) where { | ||
| $new_import = "import a.b.Text;", | ||
| $body<: maybe contains ensure_import_statement($new_import) | ||
| } | ||
| ``` | ||
|
|
||
| ## test `ensure_import_statement` when there already have one | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Text text) { | ||
| this.str = text; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Text text) { | ||
| this.str = text; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
|
|
||
|
|
||
| ## test `ensure_import_statement` when missing import | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Text text) { | ||
| this.str = text; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Text text) { | ||
| this.str = text; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| # Testing `replace_import_statement` | ||
|
|
||
| ```grit | ||
| language java | ||
| replace_import_statement("import a.b.Text;", "import a.c.Text;") | ||
| ``` | ||
|
|
||
| ## test `replace_import_statement` when have | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
| import a.b.Form; | ||
|
|
||
| import a.b.Text; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.c.Text; | ||
| import a.b.Form; | ||
|
|
||
| import a.c.Text; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
|
|
||
| # Testing `remove_duplicate_import_statements` | ||
|
|
||
| ```grit | ||
| language java | ||
| remove_duplicate_import_statements() | ||
| ``` | ||
|
|
||
| ## test `remove_duplicate_import_statements` when there are some duplicates | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
| import a.b.Form; | ||
|
|
||
| import a.b.Text; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
| import a.b.Form; | ||
|
|
||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## test `replace_import_statement` when there are none duplicates | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
| import a.b.Form; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| import a.b.Text; | ||
| import a.b.Form; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## test `replace_import_statement` when there are none import statements. | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```java | ||
| package xx; | ||
|
|
||
| public class AClass { | ||
| private Text str; | ||
|
|
||
| private Text getStr() { | ||
| return str; | ||
| } | ||
| private Text setStr(Form form) { | ||
| this.str = form.toText(); | ||
| } | ||
| } | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| language java | ||
|
|
||
| pattern remove_duplicate_import_statements() { | ||
| $_ where { | ||
| $GLOBAL_REMOVE_DUPLICATE_EXIST_IMPORTS = true, | ||
| } | ||
| } | ||
|
|
||
| pattern ensure_import_statement($import_decl) { | ||
| $_ where { | ||
| $GLOBAL_EXIST_IMPORTS <: not some $import_decl, | ||
| $GLOBAL_EXIST_IMPORTS += $import_decl, | ||
| $GLOBAL_NEW_FROM_IMPORTS += $import_decl, | ||
| $GLOBAL_NEW_FROM_IMPORTS = distinct($GLOBAL_NEW_FROM_IMPORTS) | ||
| } | ||
| } | ||
|
|
||
| pattern replace_import_statement($old_import, $new_import) { | ||
| $body where { | ||
| $find_all_import = [], | ||
| $body <: program(statements = $statements), | ||
| $statements <: bubble($find_all_import, $old_import, $new_import) every { | ||
| or { | ||
| bubble($old_import, $new_import, $find_all_import) import_declaration() as $this_import where { | ||
| if ($this_import <: $old_import) { | ||
| $this_import => `$new_import` | ||
| } | ||
| }, | ||
| $_ | ||
| } | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| pattern remove_import_statement($import_statement) { | ||
| $_ where { | ||
| $GLOBAL_REMOVE_IMPORTS += $import_statement | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.