Skip to content

Remove wrong rule to fix issue #35 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Remove wrong rule to fix issue #35 #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a225275
Remove wrong rule to fix issue #35
roflmaostc Mar 21, 2023
79cd82a
Remove another wrong rule
roflmaostc Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions src/convolutions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,18 +74,6 @@ function conv_psf(u::AbstractArray{T, N}, psf::AbstractArray{D, M}, dims=ntuple(
return conv(u, ifftshift(psf, dims), dims)
end

# define custom adjoint for conv
# so far only defined for the derivative regarding the first component
function ChainRulesCore.rrule(::typeof(conv), u::AbstractArray{T, N}, v::AbstractArray{D, M},
dims=ntuple(+, min(N, M))) where {T, D, N, M}
Y = conv(u, v, dims)
function conv_pullback(barx)
z = zero(eltype(u))
return NoTangent(), conv(barx, conj(v), dims), z, z
end
return Y, conv_pullback
end



"""
Expand Down Expand Up @@ -219,15 +207,6 @@ function p_conv_aux(P, P_inv, u, v_ft)
return (P_inv.p * ((P * u) .* v_ft .* P_inv.scale))
end

function ChainRulesCore.rrule(::typeof(p_conv_aux), P, P_inv, u, v)
Y = p_conv_aux(P, P_inv, u, v)
function conv_pullback(barx)
z = zero(eltype(u))
∇ = p_conv_aux(P, P_inv, barx, conj(v))
return NoTangent(), z, z, ∇, z
end
return Y, conv_pullback
end

"""
fft_or_rfft(T)
Expand Down