Refactor Bio::Species tests into modular files#403
Open
HussainAther wants to merge 5 commits intobioperl:masterfrom
Open
Refactor Bio::Species tests into modular files#403HussainAther wants to merge 5 commits intobioperl:masterfrom
HussainAther wants to merge 5 commits intobioperl:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the existing t/Species.t into modular test files for clarity and maintainability, adds focused memory-leak and taxonomy database tests, and introduces dedicated interface tests for Bio::SeqI and Bio::AnnotationI.
- Split species tests into three files: basic functionality, memory regressions, and Entrez DB integration.
- Added standalone tests for
Bio::SeqIandBio::AnnotationI. - Ensured network-dependent tests are skipped cleanly when unavailable.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| t/Species/basic.t | Core constructor, binomial, genus, and subspecies behavior tests |
| t/Species/memory.t | Memory-leak checks and regressions using Test::Memory::Cycle & Weaken |
| t/Species/taxonomy_db.t | Entrez Taxonomy database fetch tests with skip on network failures |
| t/SeqI.t | Interface compliance tests for Bio::SeqI |
| t/AnnotationI.t | Interface compliance tests for Bio::AnnotationI |
Comments suppressed due to low confidence (1)
t/Species/basic.t:4
- The test plan declares 8 tests, but only 7 assertions are present. Please adjust the test count or add the missing test.
use Test::More tests => 8;
Please update to include recommended Copilot change Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits
t/Species.tinto modular test files for maintainability:t/Species/basic.t– basic method and constructor testst/Species/memory.t– memory leak and regression testst/Species/taxonomy_db.t– Entrez Taxonomy DB fetch tests (with skip)This supports clearer test separation and easier maintenance going forward.