Skip to content

Clear scroll id context #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
everaldorodrigo merged 4 commits into from
Oct 28, 2025
Merged

Clear scroll id context #419

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74dde58
Clear Elasticsearch scroll_id context.
everaldorodrigo Oct 10, 2025
f44bd49
Improve error handling.
everaldorodrigo Oct 24, 2025
8c9f67c
Refactor code.
everaldorodrigo Oct 27, 2025
dbc1a98
Refactor code.
everaldorodrigo Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions biothings/web/query/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,15 @@
"""

import asyncio
import logging

from elasticsearch import NotFoundError, RequestError
from elasticsearch.dsl import MultiSearch, Search

from biothings.web.query.builder import ESScrollID

logger = logging.getLogger(__name__)


class ResultInterrupt(Exception):
def __init__(self, data):
Expand Down Expand Up @@ -139,6 +142,13 @@ async def execute(self, query, **options):
raise RawResultInterrupt(res)

if not res["hits"]["hits"]:
scroll_id=query.data
try:
await self.client.clear_scroll(scroll_id=scroll_id)
logger.info("Scroll context cleared: %s", scroll_id)
except NotFoundError as e:
logger.warning("Scroll context not found (ID: %s): %s", scroll_id, str(e))
# Always raise this exception regardless of whether clear_scroll succeeds
raise EndScrollInterrupt()

return res
Expand Down