Skip to content

Bulk Indexing Error Improvement #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DylanWelzel merged 2 commits into from
Oct 28, 2025
Merged

Bulk Indexing Error Improvement #425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
435db00
fix: improve error handling in bulk indexing with detailed logging
DylanWelzel Oct 14, 2025
76b3f85
fix: replace json serialization with to_json for error logging in bul…
DylanWelzel Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions biothings/hub/dataindex/indexer_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

from biothings.utils.es import ESIndex as BaseESIndex
from biothings.utils.loggers import get_logger
from biothings.utils.serializer import to_json

try:
from biothings.utils.mongo import doc_feeder
Expand Down Expand Up @@ -92,8 +93,12 @@ def _action(doc):
self.logger.error(error)
self.logger.error("Document ID %s failed: %s", document_id, reason)

self.logger.warning("Discovered errors during the bulk index task. Defaulting to 0 indexed documents")
return 0
serialized_errors = to_json(errors, indent=True)
message = (
f"Bulk indexing failed for index '{self.index_name}'. "
f"Elasticsearch responded with errors:\n{serialized_errors}"
)
raise helpers.BulkIndexError(message, errors) from e

# NOTE
# Why doesn't "mget", "mexists", "mindex" belong to the base class?
Expand Down