Canarie-api: add old config file into historical gitignore#314
Merged
mishaschwartz merged 2 commits intomasterfrom Apr 12, 2023
Merged
Canarie-api: add old config file into historical gitignore#314mishaschwartz merged 2 commits intomasterfrom
mishaschwartz merged 2 commits intomasterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
tlvu
approved these changes
Apr 12, 2023
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1443/Result : success BIRDHOUSE_DEPLOY_BRANCH : backwards-compatible-at-all-costs DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1065/NOTEBOOK TEST RESULTS |
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1445/Result : failure BIRDHOUSE_DEPLOY_BRANCH : backwards-compatible-at-all-costs DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca Infrastructure deployment failed. Instance has not been destroyed. @matprov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In order to maintain backwards compatibility, old files that are no longer present in the code should be
kept in the gitignore files. This adds back one file to the relevant .gitignore file that no longer exists under
conf.extra-service.d/canarie-api.conf.Changes
Non-breaking changes
Add old file to gitignore
Breaking changes
None
Related Issue / Discussion
See: #310 (comment)
Additional Information