Skip to content

Canarie-api: add old config file into historical gitignore#314

Merged
mishaschwartz merged 2 commits intomasterfrom
backwards-compatible-at-all-costs
Apr 12, 2023
Merged

Canarie-api: add old config file into historical gitignore#314
mishaschwartz merged 2 commits intomasterfrom
backwards-compatible-at-all-costs

Conversation

@mishaschwartz
Copy link
Collaborator

Overview

In order to maintain backwards compatibility, old files that are no longer present in the code should be
kept in the gitignore files. This adds back one file to the relevant .gitignore file that no longer exists under
conf.extra-service.d/canarie-api.conf.

Changes

Non-breaking changes

Add old file to gitignore

Breaking changes

None

Related Issue / Discussion

See: #310 (comment)

Additional Information

@crim-jenkins-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1443/
Result : success

BIRDHOUSE_DEPLOY_BRANCH : backwards-compatible-at-all-costs
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-88.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1065/

NOTEBOOK TEST RESULTS
    
[2023-04-12T17:18:26.361Z] ============================= test session starts ==============================
[2023-04-12T17:18:26.361Z] platform linux -- Python 3.8.16, pytest-7.2.0, pluggy-1.0.0
[2023-04-12T17:18:26.361Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2023-04-12T17:18:26.361Z] plugins: anyio-3.6.2, dash-2.7.0, nbval-0.9.6, tornasync-0.6.0.post2
[2023-04-12T17:18:26.361Z] collected 268 items
[2023-04-12T17:18:26.361Z] 
[2023-04-12T17:18:35.839Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-04-12T17:18:51.485Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  6%]
[2023-04-12T17:18:59.172Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [  8%]
[2023-04-12T17:19:07.483Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 11%]
[2023-04-12T17:19:10.591Z] pavics-sdi-master/docs/source/notebooks/WPS_example.ipynb ..........     [ 15%]
[2023-04-12T17:26:54.357Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 20%]
[2023-04-12T17:26:55.295Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 20%]
[2023-04-12T17:27:00.227Z] ...............                                                          [ 26%]
[2023-04-12T17:27:10.265Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 27%]
[2023-04-12T17:27:17.886Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 30%]
[2023-04-12T17:27:34.070Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 32%]
[2023-04-12T17:27:35.454Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 32%]
[2023-04-12T17:27:40.671Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 35%]
[2023-04-12T17:27:47.457Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 37%]
[2023-04-12T17:32:45.920Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 42%]
[2023-04-12T17:33:56.350Z] .............                                                            [ 47%]
[2023-04-12T17:34:01.849Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 49%]
[2023-04-12T17:34:04.057Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 52%]
[2023-04-12T17:34:24.345Z] .................                                                        [ 58%]
[2023-04-12T17:34:31.660Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb .....           [ 60%]
[2023-04-12T17:34:33.566Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 60%]
[2023-04-12T17:34:49.596Z] .........                                                                [ 64%]
[2023-04-12T17:35:01.515Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 68%]
[2023-04-12T17:35:11.555Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 70%]
[2023-04-12T17:35:48.686Z] finch-master/docs/source/notebooks/subset.ipynb ....................ss.  [ 79%]
[2023-04-12T17:35:50.065Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 79%]
[2023-04-12T17:35:54.206Z] ......                                                                   [ 81%]
[2023-04-12T17:36:26.304Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 82%]
[2023-04-12T17:36:48.243Z] .............                                                            [ 86%]
[2023-04-12T17:36:58.225Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 87%]
[2023-04-12T17:38:02.082Z] ....s.                                                                   [ 89%]
[2023-04-12T17:38:10.230Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 89%]
[2023-04-12T17:38:16.068Z] ...                                                                      [ 91%]
[2023-04-12T17:38:30.972Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 91%]
[2023-04-12T17:38:53.385Z] ......                                                                   [ 93%]
[2023-04-12T17:38:56.114Z] notebooks/hummingbird.ipynb ............                                 [ 98%]
[2023-04-12T17:42:30.789Z] notebooks/stress-tests.ipynb .....                                       [100%]
[2023-04-12T17:42:30.789Z] 
[2023-04-12T17:42:30.789Z] ================= 265 passed, 3 skipped in 1439.15s (0:23:59) ==================
    
  

@github-actions github-actions bot added ci/operations Continuous Integration components documentation Improvements or additions to documentation labels Apr 12, 2023
@mishaschwartz mishaschwartz merged commit 511d9ce into master Apr 12, 2023
@mishaschwartz mishaschwartz deleted the backwards-compatible-at-all-costs branch April 12, 2023 21:50
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1445/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : backwards-compatible-at-all-costs
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-88.rdext.crim.ca

Infrastructure deployment failed. Instance has not been destroyed. @matprov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/operations Continuous Integration components documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants