Added a function for parsing AllowedValues#278
Open
RezwanM wants to merge 16 commits intobird-house:masterfrom
Open
Added a function for parsing AllowedValues#278RezwanM wants to merge 16 commits intobird-house:masterfrom
RezwanM wants to merge 16 commits intobird-house:masterfrom
Conversation
Zeitsperre
requested changes
Aug 28, 2025
Contributor
Zeitsperre
left a comment
There was a problem hiding this comment.
I'm wondering now whether the issue with the list of values is here or is deeper within OWSLib.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Author
|
Hi, @Zeitsperre. I added some changes which addresses the issues you mentioned above. However, the tests are failing due to a ConnectionError. |
cehbrecht
approved these changes
Sep 5, 2025
Member
|
@RezwanM @Zeitsperre just come comments:
|
Author
|
huard
reviewed
Oct 23, 2025
| The formatted docstring for this process. | ||
| """ | ||
| doc = [process.abstract or "", ""] | ||
| _process = wps.describeprocess(process.identifier) |
Contributor
There was a problem hiding this comment.
I'm confused why this is necessary. In my recollection, WPSClient._processes is a dict with the output of describeprocess, so isn't _process exactly the same as process ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes #277
Changes:
AllowedValues. The problem seemed to be that the attributeallowedValuesof theProcessDescriptionobject was being parsed byOWSLibas a Pythonset, which is inherently unordered. Parsing the elementAllowedValuesdirectly from raw XML into alistensures the original order of items inAllowedValuesis preserved.Related Issue / Discussion
Additional Information
Links to other issues or sources.