Add Hdf5 serialization functions for read and write data objects#221
Merged
ethanplunkett merged 36 commits intobirdflow-science:mainfrom Sep 29, 2025
chenyangkang:hdf5_serialization
Merged
Add Hdf5 serialization functions for read and write data objects#221ethanplunkett merged 36 commits intobirdflow-science:mainfrom chenyangkang:hdf5_serialization
ethanplunkett merged 36 commits intobirdflow-science:mainfrom
chenyangkang:hdf5_serialization
Conversation
…docs; update version; update changelog
Contributor
Author
|
@ethanplunkett Hi Ethan, can we consider merging this after merging the other PR? I'm working on combining the multi-source data and these functions seem to be essential if we want them in hdf5 format. Please let me know if there are any concerns. |
…the^Crite-read action
Contributor
Author
|
@ethanplunkett Revised based on you suggestions:
|
- Use tempdir for writing - with promise to delete - Fix tests for compatibility with NULL writes - it now fails
Contributor
|
@chenyangkang I updated the tests for serialization:
|
Contributor
|
I fixed the tests so it's actually testing with a NULL list, but now it's failing. I think we should just drop those tests as I'm not aware of anytime that we'll be writing NULL values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for issue #220