knet_manager: fix deadlock on port creation#486
Merged
Conversation
When creating ports in knet_manager::create_portdev(), they are created with tn_mutex held, and calls knet_manager::change_port_status() to set the initial config to down. Since commit cefce26 ("knet_manager: do not try to set state for non-existing links"), knet_manager::change_port_status() also takes the mutex, leading to a deadlock on port creation. Fix this by providing a non-locking variant of knet_manager::change_port_status() to use by knet_manager::create_portdev(). Fixes: cefce26 ("knet_manager: do not try to set state for non-existing links") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating ports in
knet_manager::create_portdev(), they are created withtn_mutexheld, and it callsknet_manager::change_port_status()to set the initial config to down.Since commit cefce26 ("knet_manager: do not try to set state for non-existing links"),
knet_manager::change_port_status()also takes the mutex, leading to a deadlock on port creation.Fix this by providing a non-locking variant of
knet_manager::change_port_status()to use byknet_manager::create_portdev().Fixes: cefce26 ("knet_manager: do not try to set state for non-existing links")